SegWit by libbitc · Pull Request #104 · jgarzik/picocoin

libbitc · 2017-08-18T22:38:09Z

Hi,

This PR adds SegWit functionality to picocoin.
All json test files in test/data directory copied from bitcoin core 14.2

coveralls · 2017-08-18T23:13:29Z

Coverage increased (+0.2%) to 78.767% when pulling 3da9804 on libbitc:picocoin into faa9b83 on jgarzik:master.

coveralls · 2017-08-18T23:13:29Z

Coverage increased (+0.2%) to 78.767% when pulling 3da9804 on libbitc:picocoin into faa9b83 on jgarzik:master.

jgarzik · 2017-08-19T02:45:07Z

Nice! Thanks a bunch. concept ACK

Does the default-off sync test work on segwit or segwit2x testnet chains?

libbitc · 2017-08-21T01:04:05Z

Hi,

SegWit aside the default-off chain-verf test does not pass for testnet3 blocks:

chain-verf: validating testnet3 chainfile /bitcoin/bootstrap.testnet3.dat (*script)
chain-verf: spend block @ 0
chain-verf: spend block @ 5000
chain-verf: spend block @ 10000
chain-verf: spend block @ 15000
chain-verf: tx fail 970b18f67be0b86b8994223a87ef445431e5efc03fe2191034e9dad0c17dd6d3
chain-verf: block fail 16306 000000001531abe940a7983079579fa4e28217ec854b0189d184de744e475b88
chain-verf: chain-verf.c:164: read_test_msg: Assertion `!"spend_block"' failed.
FAIL chain-verf (exit status: 134)

This problem was introduced with changes made in commit 5475db7.

Will add some fixes for this.

coveralls · 2017-08-21T01:37:13Z

Coverage increased (+0.2%) to 78.767% when pulling 24097bb on libbitc:picocoin into faa9b83 on jgarzik:master.

coveralls · 2017-08-21T01:37:13Z

Coverage increased (+0.2%) to 78.767% when pulling 24097bb on libbitc:picocoin into faa9b83 on jgarzik:master.

coveralls · 2017-08-27T19:08:02Z

Coverage increased (+0.1%) to 78.733% when pulling 7787e4c on libbitc:picocoin into faa9b83 on jgarzik:master.

libbitc · 2017-09-02T03:18:20Z

Hi,

The most recent commit to this PR successfully validates 1179472 blocks of the testnet3 chain.
The block time of block 1179472 is 2017-08-20 03:31:53. testnet3 supports SegWit as of block 834624.(2016-05-13 00:22:51)

chain-verf: validating testnet3 chainfile /libbitc/test/data/bootstrap.testnet3.dat.1179500 (+script)
chain-verf: spend block @ 0
chain-verf: spend block @ 5000
chain-verf: spend block @ 10000
chain-verf: spend block @ 15000
chain-verf: spend block @ 20000
chain-verf: spend block @ 25000
chain-verf: spend block @ 30000
.
.
.
chain-verf: spend block @ 80000
chain-verf: spend block @ 85000
chain-verf: spend block @ 90000
chain-verf: spend block @ 95000
chain-verf: spend block @ 100000
.
.
.
chain-verf: spend block @ 1150000
chain-verf: spend block @ 1155000
chain-verf: spend block @ 1160000
chain-verf: spend block @ 1165000
chain-verf: spend block @ 1170000
chain-verf: spend block @ 1175000
chain-verf: 1179472 records validated
PASS chain-verf (exit status: 0)

Test performed with FORCE_SCRIPT_VERF=1.

jgarzik · 2017-08-31T14:00:42Z

lib/script_names.c

+    char tmpname[256];

-	for (i = 0; i < ARRAY_SIZE(opnames); i++) {
+    for (i = 0; i < ARRAY_SIZE(opnames); i++) {


nit: indent changes

jgarzik · 2017-08-31T14:01:33Z

lib/script_sign.c

+    bp_tx_sighash(&hash, fromPubKey, txTo, nIn, nHashType, 0, 0);

-	/* match fromPubKey against templates, to find what pubkey[hashes]
+    /* match fromPubKey against templates, to find what pubkey[hashes]


jgarzik · 2017-08-31T14:02:01Z

test/Makefile.am


-noinst_LIBRARIES= libtest.a
+check_LTLIBRARIES = libtest.la



This is a noinst lib. Why change to libtool?

I thought the check_ prefix did not work with the LIBRARIES primary but I was mistaken. Reading the automake manual I now see that:

The special prefix ‘check_’ indicates that the objects in question should not be built until the ‘make check’ command is run. Those objects are not installed either.

The current primary names are ‘PROGRAMS’, ‘LIBRARIES’, ‘LTLIBRARIES’, ‘LISP’, ‘PYTHON’, ‘JAVA’, ‘SCRIPTS’, ‘DATA’, ‘HEADERS’, ‘MANS’, and ‘TEXINFOS’.

Also, check_ prefix has slightly negative value versus noinst_, because it reduces the amount of code built by default, which prevents immediate notification of test breakage caused by a non-test code bug.

Latest commit reverts check_ prefix to noinst_

jgarzik · 2017-08-31T14:03:05Z

test/script.c

+ * file COPYING or http://www.opensource.org/licenses/mit-license.php.
+ */

-#include "picocoin-config.h"


This was dropped. Not needed?

Running test/script.c through iwyu tool would suggest so.

jgarzik · 2017-08-31T14:03:22Z

test/script.c

+    const char* scriptPubKeyString,
+    const unsigned int test_flags,
+    int64_t nValue)
 {


nit: non-standard indent versus rest of project.

libbitc · 2017-09-02T12:11:12Z

Hi,

Non-standard indentations noted. .clang-format config seems to be doing some strange things. Will fix.

coveralls · 2017-09-02T19:14:07Z

Coverage decreased (-0.9%) to 77.642% when pulling 8a454a9 on libbitc:picocoin into faa9b83 on jgarzik:master.

coveralls · 2017-09-02T20:25:37Z

Coverage decreased (-0.9%) to 77.642% when pulling 8fbaf2c on libbitc:picocoin into faa9b83 on jgarzik:master.

libbitc force-pushed the picocoin branch 2 times, most recently from 259c42e to 24097bb Compare August 21, 2017 01:23

libbitc changed the title ~~SegWit~~ WIP: SegWit Aug 21, 2017

libbitc force-pushed the picocoin branch from 24097bb to 7787e4c Compare August 27, 2017 18:55

libbitc changed the title ~~WIP: SegWit~~ SegWit Sep 2, 2017

jgarzik reviewed Sep 2, 2017

View reviewed changes

libbitc force-pushed the picocoin branch from 7787e4c to 8a454a9 Compare September 2, 2017 18:59

libbitc added 3 commits September 2, 2017 19:34

ccoin: Implement SegWit in script functionality and tests

2dc86b9

ccoin: Implement SegWit in tx functionality and tests

3038a8c

ccoin: Add some checkpoints

8fbaf2c

libbitc force-pushed the picocoin branch from 8a454a9 to 8fbaf2c Compare September 2, 2017 20:11


		noinst_LIBRARIES= libtest.a
		check_LTLIBRARIES = libtest.la

Conversation

libbitc commented Aug 18, 2017

Uh oh!

coveralls commented Aug 18, 2017

Uh oh!

coveralls commented Aug 18, 2017

Uh oh!

jgarzik commented Aug 19, 2017

Uh oh!

libbitc commented Aug 21, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coveralls commented Aug 21, 2017

Uh oh!

coveralls commented Aug 21, 2017

Uh oh!

coveralls commented Aug 27, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

libbitc commented Sep 2, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

libbitc Sep 2, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

libbitc commented Sep 2, 2017

Uh oh!

coveralls commented Sep 2, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coveralls commented Sep 2, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

libbitc commented Aug 21, 2017 •

edited

Loading

coveralls commented Aug 27, 2017 •

edited

Loading

libbitc Sep 2, 2017 •

edited

Loading

coveralls commented Sep 2, 2017 •

edited

Loading

coveralls commented Sep 2, 2017 •

edited

Loading