-
Notifications
You must be signed in to change notification settings - Fork 455
Add the ability to add an app shortcut to open chuck from the launcher icon #49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
degill
wants to merge
1
commit into
jgilfelt:master
Choose a base branch
from
degill:dg_app_shortcut
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -15,10 +15,16 @@ | |
| */ | ||
| package com.readystatesoftware.chuck; | ||
|
|
||
| import android.annotation.TargetApi; | ||
| import android.content.Context; | ||
| import android.content.Intent; | ||
|
|
||
| import android.content.pm.ShortcutInfo; | ||
| import android.content.pm.ShortcutManager; | ||
| import android.graphics.drawable.Icon; | ||
| import android.os.Build; | ||
| import android.support.annotation.Nullable; | ||
| import com.readystatesoftware.chuck.internal.ui.MainActivity; | ||
| import java.util.Collections; | ||
|
|
||
| /** | ||
| * Chuck utilities. | ||
|
|
@@ -34,4 +40,30 @@ public class Chuck { | |
| public static Intent getLaunchIntent(Context context) { | ||
| return new Intent(context, MainActivity.class).setFlags(Intent.FLAG_ACTIVITY_NEW_TASK); | ||
| } | ||
|
|
||
| /** | ||
| * Register an app shortcut to launch the Chuck UI directly from the launcher on Android 7.0 and above. | ||
| * | ||
| * @param context A valid {@link Context} | ||
| * @return The id of the added shortcut (<code>null</code> if this feature is not supported on the device). | ||
| * It can be used if you want to remove this shortcut later on. | ||
| */ | ||
| @TargetApi(Build.VERSION_CODES.N_MR1) | ||
| @SuppressWarnings("WeakerAccess") | ||
| @Nullable | ||
| public static String addAppShortcut(Context context) { | ||
| if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.N_MR1) { | ||
| final String id = context.getPackageName() + ".chuck_ui"; | ||
| final ShortcutManager shortcutManager = context.getSystemService(ShortcutManager.class); | ||
| final ShortcutInfo shortcut = new ShortcutInfo.Builder(context, id).setShortLabel("Chuck") | ||
| .setLongLabel("Open Chuck UI") | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The label should be retrieved from the resources, or maybe given by paramters to let de developer choose the wording. |
||
| .setIcon(Icon.createWithResource(context, R.drawable.chuck_ic_notification_white_24dp)) | ||
| .setIntent(getLaunchIntent(context).setAction(Intent.ACTION_VIEW)) | ||
| .build(); | ||
| shortcutManager.addDynamicShortcuts(Collections.singletonList(shortcut)); | ||
| return id; | ||
| } else { | ||
| return null; | ||
| } | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not fan of this SuppressWarnings
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This function is obviously not called from within the library, thus there will be a warning that its access can be weaker, but apps need access to it so it must be public -> Get rid of the warning.