Make request body format customizable (Issue 54)#60
Open
dmitrikudrenko wants to merge 1 commit intojgilfelt:masterfrom
dmitrikudrenko:master
Open
Make request body format customizable (Issue 54)#60dmitrikudrenko wants to merge 1 commit intojgilfelt:masterfrom dmitrikudrenko:master
dmitrikudrenko wants to merge 1 commit intojgilfelt:masterfrom
dmitrikudrenko:master
Conversation
dmitrikudrenko
changed the title
olivierperez
suggested changes
Sep 19, 2018
| JsonConvertor.gson = gson; | ||
| } | ||
|
|
||
| public static GsonBuilder getDefaultGsonBuilder() { |
There was a problem hiding this comment.
This is not a getter, it cannot be called "get...", maybe something like "createDefaultGsonBuilder" could be nice.
| } | ||
|
|
||
| @NonNull | ||
| private ChuckInterceptor createChuckInterceptor(Context context) { |
There was a problem hiding this comment.
You add a method called "createChuckInterceptor", but it is not its only purpose. I see it also do some configuration of another class.
The configuration of JsonConverter could be done in the Application class, or within the onCreate of this activity.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#54