Fixes #3961 #3990
Open
Fixes #3961 #3990
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YorikHansen
added a commit
to YorikHansen/bulma
that referenced
this pull request
May 29, 2025
This is the alternative implementation as mentioned in the PR jgthms#3990. Related issue: jgthms#3961
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a bugfix.
Resolves #3961
Proposed solution
The usage of media range syntax fixes this issue. According to Can I use, this syntax is baseline available since 2023.
Tradeoffs
This is not as backwards compatible as the old
max-width. Alternatively one could use the same workaround as bootstrap and subtract only0.02px. See the alternative implementation here.Testing Done
(Note: due to a rounding error, my viewport has actually a width between
1023pxand1024px)1022px1023px1024pxChangelog updated?
No.