More accurate categorizing of some elements #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
September 15, 2017 08:20
The `<dd>` element can contain non-Phrasing [Flow content](https://html.spec.whatwg.org/multipage/grouping-content.html#the-dd-element) ("block" elements, in HTML4 terms) and can itself appear only in the same places where its `<dt>` counterpart can appear. So the definitions of these elements should probably be treated the same way, and the `<dd>` clearly can't be considered "inline" element
The `<select>` element is categorized as "[Phrasing content](https://html.spec.whatwg.org/multipage/form-elements.html#the-select-element)" (correponding to "Inline" elements in HTML4 terms) and doesn't break a line of text (exactly like, e.g., `<input type="text">`), so it should be categorized the same way.
The `<ruby>` element is part of "Text level semantics" section of the spec and is categorized as "[Phrasing content](https://html.spec.whatwg.org/multipage/text-level-semantics.html#the-ruby-element)" (corresponding to "Inline elements" in HTML4 terms). It doesn't break lines as "block elements" do.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some elements seems to have incorrect "type". More details in the file change comments.