websockets serve needs to run async to work #58
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated WebSocket server implementation to use `asyncio.server.serve` for better encapsulation and async handling. Adjusted URL decoding logic to correct path parsing. Modified the `start_servers` call in examples to include a stop condition for improved flexibility.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the starting of the websockets async server, so that the call to serve is also async.
The (newer?) websockets version does not expect a path as argument for the serve function, so that was removed as well.
I also encountered the bug of a not merged pull request (Windows 11 path starting with a '/' like "/C:/Users/...") so I updated this as well.