Change syncoid snapshots date and time divider from ":" to "_" #1044
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now the sanoid and syncoid snapshots are parsing the date and time differently:
Sanoid appends e.g.
_2023-07-25_20:00:14-GMT03:00whileSyncoid appends
_2023-07-25:20:00:14-GMT03:00.Basically, Syncoid uses a
:to divide the date and the time, while Sanoid uses a_to do that.If this isnt intended behavious, this pull request would just replace the
:with a_in the syncoid data-parsing.As the
get_date()function is only used at one place in Syncoid (setting the name for a new snapshot), this change wouldn't break anything as far as I can tell