Updated constructors to return instancetype to improve swift compatibility#50
Open
twobitlabs wants to merge 1 commit intojivadevoe:masterfrom
Open
Updated constructors to return instancetype to improve swift compatibility#50twobitlabs wants to merge 1 commit intojivadevoe:masterfrom
twobitlabs wants to merge 1 commit intojivadevoe:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using UIAlertView+Blocks in swift, the
idconstructors are exposed as static methods returningAnyObject!:Updating them to return
instancetypeexposes some more expected initializers:It actually feels like more of a side effect than a direct result of this change, but the
instancetypemethods feel cleaner and the result is more usable in Swift.