Add optional EB alignment prior to self-calibration#110
Open
psheehan wants to merge 43 commits intojjtobin:mainfrom
Open
Add optional EB alignment prior to self-calibration#110psheehan wants to merge 43 commits intojjtobin:mainfrom
psheehan wants to merge 43 commits intojjtobin:mainfrom
Conversation
…me updates to make this happen: - Correcting data types in a few places - Specify the grid in pixel space and then multiply by du and dv to avoid rounding errors leading to inconsistencies in specified grid size - Supply target to find_offset in main call. - Make suffix a specifiable value and set to '' for .selfcal.ms files so that they are edited in-place
…e and update the applycal and uvcontsub scripts to work on this .shift.ms file. This includes a change that if update_phase_center finds that the vis+suffix ms file already exists (e.g. multiple sources), then update the current source on that file in-place.
…a, including: - Better calibration/combination of weights - Add a prior of a zero offset with a ~5% beam width uncertainty - Fit using MCMC (or Nested Sampling) - Also make a map of the log likelihood - Make before and after images of each individual EB.
- Switch to fitting phase differences between EBs - Properly calibrate data weights - More accurately calculate phase uncertainties - Make inclusion of residual phase errors after gaincal optional - Remove the need for the directory of the caltables as it is not used anymore
…ng phase uncertainties on the data.
…of the image, as estimated by the visibility data.
… alignment. Also, make alignment optional.
…pip_installable+EB_alignment
…pip_installable+EB_alignment
…pip_installable+EB_alignment
…pip_installable+EB_alignment
…e_pip_installable+EB_alignment
|
Codecov Report❌ Patch coverage is
🚀 New features to boost your workflow:
|
Collaborator
Author
|
Note following discussion with @jjtobin - add shift to one EB of the Band8-7m-2 test to test that EB alignment gets the correct answer. |
…three need to be run. Because of this, emcee and dynesty can be optional again. All three options now make a plot with the same name, for future weblog purposes.
…single EB datasets don't run through align_measurement_sets (and therefore end up with offsets and try to make the weblog).
…alues and weblog, with EB alignment added.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the optional ability to align EBs with a visibility based alignment. This is currently only allowed for single fields, as more thought may be needed as to how to manage this for mosaics.
Two decisions/updates need to be made before this is ready to be merged: