Pass through otherwise flagged antennas for inf_EB when solutions are overall weak#42
Open
psheehan wants to merge 3 commits intojjtobin:mainfrom
Open
Pass through otherwise flagged antennas for inf_EB when solutions are overall weak#42psheehan wants to merge 3 commits intojjtobin:mainfrom
psheehan wants to merge 3 commits intojjtobin:mainfrom
Conversation
…edo and check for/pass through failed antennas if the solutions are all weak (mean SNR < 5)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A number of cases have come up in operations where the inf_EB solint succeeds because the SNR goes up, but because of flagging the RMS also goes up, in some cases by a considerable amount, due to flagging in the inf_EB solutions. In many of these cases, the SNR of all of the solutions, not just the ones that were flagged, tends to be quite low, which leads me to believe that in these cases the data are just overall fairly low SNR (at least as far as selfcal is concerned) rather than the flagged data truly being bad.
To remedy this, this PR implements a new fallback mode wherein if the inf_EB solint passes with combinespw but RMS increases by more than 2%, it will redo inf_EB and check for/pass through failed antennas if the solutions are all weak (mean SNR < 5). I implemented this as a repeat of the solint rather than simply looking for overall low SNR inf_EB solutions and passing through the flagged ones at the outset as it seemed to me that it would be better to let inf_EB pass with the flagged solutions if it doesn't dramatically harm the RMS.
A few other points that might be worth some thought:
I've tested this on two datasets that show this problem and both look good. I want to do testing on a broader range of data to see how it impacts the overall inf_EB solint before we merge.