Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
src/renderer/src/pages/Sessions/ImprovToolTab.tsxincluding input fields and DM-ready output cards fordialogueOpener,motive,secret,escalationBeat, andfallbackBeat.getDefaultImprovEntityRefsinsrc/renderer/src/lib/improv/context.ts.src/renderer/src/lib/improv/:types.ts(contracts),context.ts(context synthesis and formatting), andgenerate.ts(LLM integration with JSON-schema expectations andfallbackGeneratefor robust fallback outputs).Improvtab to the session sidebar and renderingImprovToolTabfromSessionDetail, and added lightweight defensive typing/formatting tweaks to the new files.Testing
npm run lint(executed repository lint) and it failed due to pre-existing, repository-wide lint/type style issues outside the scope of this PR; failures are unrelated to the improv feature.npm run typecheckand both node and web type checks passed successfully.npx viteand captured a Playwright screenshot of the improv tab UI; Electron runtime failed to launch in this environment due to a missing system library (libatk-1.0.so.0), so full Electron smoke-test was not possible.VITE_LLM_*or localimprovTool.llmConfig, requests ajson_schemaresponse, and only accepts outputs that satisfy required keys (returnsusedFallback: falseand diagnostics on success); the fallback path was validated by code paths for missing config, non-OK HTTP responses, missing/malformed content, schema mismatch, and request exceptions, and always produces complete, DM-usable beats viafallbackGenerate.Codex Task