Static typing - inline annotations #200
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an alternative approach to #199.
I managed to avoid importing
collections.abc,types, andtyping_extensionsby using stringified annotations. There's no way to get around thetypingimport though, so aimport threadpoolctlcould still be slightly slower for projects that didn't already importtyping.Personally, I like this better than #199, and it's not as messy as I had expected it might be.
Compared to #199, this is also compatible with more type-checkers, namely pyright, basedpyright (a stricter pyright fork), and ty (by the same authors as ruff and uv). Mypy and the pyrights are configured in strict mode, meaning that they'll complain if they aren't able to infer some type. So that's 100% type-coverage.
I tried my best not to touch the the runtime code for as much as I could. In some cases I had to make slight adjustments, but those should not have any effect on the behavior.