Develop #51
Closed
Develop #51
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Upgraded to latest dependencies. Resolved issues surrounding them.
When providing a date that's in the past (without a backupStartTime, or a backup that's also in the past) the timer now no longer throws an error and immediatley finishes the timer. This allows for better handling of non persistent timers. BREAKING CHANGE: start() no longer throws an error when startTime = 0 with countdown = true. dateToSeconds also no longer throws an error when startTime or backupStartTime are in the past but now returns 0.
removed deprecated method from Timr BREAKING CHANGE: isRunning removed
Re-structured rollup config to make use of output array, rather then individual input/output ojects
Rather then the original custom date parsing, we're now using date-fns/parseISO to be fully compatible with parsing ISO8601 dates. BREAKING CHANGE: When passing an invalid date format, e.g. (0000-00-00). Previously an error would be thrown when it couldn't be parsed with a message starting: 'The provided date is not in the right format or is incorrect.'. Now it will throw an error with a message: 'Expected time to be in (hh:mm:ss) format, instead got: 0000-00-00'. This is due to the fact that the parsing logic is passed over to the timeToSeconds function when a parseISO returns an "Invalid Date".
Update node version in github actions from 15 to 18
Feature/date parsing improvements
Pull Request Test Coverage Report for Build 16165826167Details
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.