[php2cpg] fix: binding table fix #5715
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ml86
requested changes
Dec 4, 2025
| diffGraph.addEdge(typeDecl, bindingNode, EdgeTypes.BINDS) | ||
| diffGraph.addEdge(bindingNode, method, EdgeTypes.REF) | ||
| otherBodyStmts.flatMap(_.root).collect { | ||
| case method: NewMethod if method.name != "<global>" => |
Contributor
There was a problem hiding this comment.
Having a the <global> method in the bodyStmts of a class already seems wrong. Please fix that instead of filtering this method out here.
Member
Author
There was a problem hiding this comment.
@ml86 this seems to be due to how the parser represents this.
There is a PhpClassLikeStmt for <global>, and in that, a PhpMethodDecl for <global>
Contributor
There was a problem hiding this comment.
Concluded in zoom that we want to go ahead with the current status as changing it would be a too big refactoring for now.
TNSelahle
force-pushed
the
tebogo/fix-binding-table
branch
from
1a114e9 to
f13cc7a
Compare
ml86
approved these changes
Dec 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing unnecessary entries from the binding table.
Fixes https://github.com/ShiftLeftSecurity/codescience/issues/8573