[pysrc2cpg] Enrich Python import nodes with location metadata and exact code in the code property (#5651) #5730
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he code property + add tests (joernio#5651)
ventusfortis
changed the title
maltek
reviewed
Jan 5, 2026
| } | ||
| } | ||
|
|
||
| override def runOnPart(diffGraph: DiffGraphBuilder, part: (Call, Assignment)): Unit = { |
Contributor
There was a problem hiding this comment.
please change the base implementation of XImportsPass.runOnPart (and/or Imports.createImportNodeAndLink which it calls) so that your improvement applies for all frontends making use of it, not just for python.
| } | ||
| } | ||
|
|
||
| private def importCodeFromCall(call: Call): String = { |
Contributor
There was a problem hiding this comment.
This is a very welcome change, but this logic doesn't belong in the imports pass.
I believe the call for the import statement is emitted here, so that's where the code field should be set to a more appropriate value:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a runOnPart method for python imports, which enriches import nodes with missing data about location (#5651 and also fixes the code property to be exact in output