Open
Conversation
Fixed read_adf11.py to have more robust pathing and a bit better optimization
Owner
|
This fails for some of the "PLT" adf11 files (they are not always consistent in format). I think this what originally caused the bug, I modified to read the PLT adf11 files. Try the "plt89_b.dat" file on openADAS. I'll investigate as well once this is solved it looks good to me to merge. |
Collaborator
|
@johnson-c @d-v-t I've now realized that read_adf11 can't read charge exchange data from CCD files. Is this something that is doable here? Otherwise I can wait till this is fixed, and then build off it to also load CCD files (it looks like is should be straightforward?) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed read_adf11.py to have more robust pathing and a bit better optimization