(UX) BottomSheet: Swipe to close share & other modal#95
Open
Taffroi wants to merge 7 commits intojoinloops:mainfrom
Open
(UX) BottomSheet: Swipe to close share & other modal#95Taffroi wants to merge 7 commits intojoinloops:mainfrom
Taffroi wants to merge 7 commits intojoinloops:mainfrom
Conversation
…s crashes & removed unnecessary padding to cancel
Taffroi
changed the title
Contributor
Author
|
I changed the code to add the BottomSheet functionnality as its own composent so it can be reused on other composents as well. Here I applied it to the OtherModal. Btw, ShareModal & OtherModal had different background colors, but since it now uses the same BottomSheet base, they are now visually consistent
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before, the share modal had a bar indicating that you could use your finger to move or close it. However, it didn't actually support swipe gestures.
With this PR, you can now swipe down to close the share modal. The condition to close it is based on the finger velocity, don't hesitate to try it on a real device to see if the threshold is good.
I also removed the extra padding at the bottom of the cancel button, as the safe areas is sufficient.