Add type declarations #2
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey Jon. This PR adds a type declarations in build, to make this code works in typescript code.
Additionally typescript compiler found a mismatch
segmentimplementation to a base class type, since it must return object with methodcontainingand iterator symbol. I've fixed that problem with stub implementation ofcontainingthat throws error if will be used. We may create issue to implement this method later.Now code compiles well. Example of generated
.d.tsfile isPlease update package once this changes will be merged. I faced with a performance problem that solves your package, so I would be happy to migrate on your solution.