Stripping of comments with double quotes is not woking #49
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he issue in removing comments
…he issue in removing comments
…he issue in removing comments
tunnckoCore
requested changes
Feb 17, 2020
| const constants = { | ||
| ESCAPED_CHAR_REGEX: /^\\./, | ||
| QUOTED_STRING_REGEX: /^(['"`])((?:\\.|[^\1])+?)(\1)/, | ||
| QUOTED_STRING_REGEX:/^(['"`])((?:|[^\1])+?)(\1)/, |
Collaborator
There was a problem hiding this comment.
Space after QUOTED_STRING_REGEX:
And I think the + should be inside, after the closing angle bracket ((?:[^\1]+)?) and remove the |
| content: "Content At quoted String comments"; | ||
| content: ""; | ||
| } | ||
|
|
Collaborator
There was a problem hiding this comment.
Something bothers me about that file :D Why it has duplicate stuff? At least we can make it with different classes and different comments.
There was a problem hiding this comment.
I just wanted to replicate multiple scenarios. Will modify :)
rekmarks
added a commit
to MetaMask/snaps
that referenced
this pull request
Jan 7, 2022
### Description Based on the discussion ChainSafe/filsnap#88 and some further investigation, I realized that the problem origin is inside the library used for stripping comments. The problem occurs if there are double quotes inside the comment, and this issue has been created inside `strip-comments` lib (jonschlinkert/strip-comments#49). Unfortunately, this PR with the fix is stale for some time now, so inside our fork of snaps-cli we used a forked version of `strip-comments` library. ### Changes In this PR I replaced `strip-comments` with our [fork](https://github.com/NodeFactoryIo/strip-comments) that: - fixes a bug with double quotes inside the comment - already contains types, so no need for importing them Co-authored-by: Mak Muftic <mak@chainsafe.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a content of string contains empty qutoes and followed by a comment with a quote, the entire thing is getting matched, causing the comments to left over in the file
Modified regex for identifying the quotes