Skip to content

[4.x] resolve PHPUnit Notices #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
heelc29 wants to merge 1 commit into
base: 4.x-dev
Choose a base branch
from
Open

[4.x] resolve PHPUnit Notices #50

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions Tests/CookieTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,12 +67,12 @@ public function test__constructDefaultBehaviour()
public function test__constructDependencyInjection()
{
$src = ['foo' => 'bar'];
$mockFilter = $this->createMock(InputFilter::class);
$stubFilter = $this->createStub(InputFilter::class);

$instance = new Cookie($src, ['filter' => $mockFilter]);
$instance = new Cookie($src, ['filter' => $stubFilter]);

$this->assertSame($src, TestHelper::getValue($instance, 'data'));
$this->assertSame($mockFilter, TestHelper::getValue($instance, 'filter'));
$this->assertSame($stubFilter, TestHelper::getValue($instance, 'filter'));
}

/**
Expand All @@ -83,9 +83,9 @@ public function test__constructDependencyInjection()
*/
public function testSetWithNewSignature()
{
$mockFilter = $this->createMock(InputFilter::class);
$stubFilter = $this->createStub(InputFilter::class);

$instance = new Cookie([], ['filter' => $mockFilter]);
$instance = new Cookie([], ['filter' => $stubFilter]);
$instance->set('foo', 'bar', ['expire' => 15, 'samesite' => 'Strict']);

$this->assertTrue(CookieDataStore::has('foo'));
Expand Down
14 changes: 7 additions & 7 deletions Tests/FilesTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,12 +40,12 @@ public function test__constructDefaultBehaviour()
public function test__constructDependencyInjection()
{
$src = ['foo' => 'bar'];
$mockFilter = $this->createMock(InputFilter::class);
$stubFilter = $this->createStub(InputFilter::class);

$instance = new Files($src, ['filter' => $mockFilter]);
$instance = new Files($src, ['filter' => $stubFilter]);

$this->assertSame($src, TestHelper::getValue($instance, 'data'));
$this->assertSame($mockFilter, TestHelper::getValue($instance, 'filter'));
$this->assertSame($stubFilter, TestHelper::getValue($instance, 'filter'));
}

/**
Expand Down Expand Up @@ -73,9 +73,9 @@ public function testGet()
],
];

$mockFilter = $this->createMock(InputFilter::class);
$stubFilter = $this->createStub(InputFilter::class);

$instance = new Files($data, ['filter' => $mockFilter]);
$instance = new Files($data, ['filter' => $stubFilter]);

$this->assertEquals('foobar', $instance->get('myfile3', 'foobar'), 'The default value is returned if data does not exist.');

Expand Down Expand Up @@ -110,9 +110,9 @@ public function testGetWithMultiLevelData()
],
];

$mockFilter = $this->createMock(InputFilter::class);
$stubFilter = $this->createStub(InputFilter::class);

$instance = new Files($data, ['filter' => $mockFilter]);
$instance = new Files($data, ['filter' => $stubFilter]);

$this->assertEquals(
[
Expand Down
2 changes: 2 additions & 0 deletions Tests/InputTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
use Joomla\Filter\InputFilter;
use Joomla\Input\Input;
use Joomla\Test\TestHelper;
use PHPUnit\Framework\Attributes\AllowMockObjectsWithoutExpectations;
use PHPUnit\Framework\Attributes\DataProvider;
use PHPUnit\Framework\MockObject\MockObject;
use PHPUnit\Framework\TestCase;
Expand All @@ -18,6 +19,7 @@
/**
* Test class for \Joomla\Input\Input.
*/
#[AllowMockObjectsWithoutExpectations]
class InputTest extends TestCase
{
/**
Expand Down
6 changes: 3 additions & 3 deletions Tests/JsonTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,12 +40,12 @@ public function test__constructDefaultBehaviour()
public function test__constructDependencyInjection()
{
$src = ['foo' => 'bar'];
$mockFilter = $this->createMock(InputFilter::class);
$stubFilter = $this->createStub(InputFilter::class);

$instance = new Json($src, ['filter' => $mockFilter]);
$instance = new Json($src, ['filter' => $stubFilter]);

$this->assertSame($src, TestHelper::getValue($instance, 'data'));
$this->assertSame($mockFilter, TestHelper::getValue($instance, 'filter'));
$this->assertSame($stubFilter, TestHelper::getValue($instance, 'filter'));
}

/**
Expand Down