Skip to content

Fix time format in calendar documentation#595

Open
cyrez wants to merge 1 commit intojoomla:mainfrom
cyrez:patch-3
Open

Fix time format in calendar documentation#595
cyrez wants to merge 1 commit intojoomla:mainfrom
cyrez:patch-3

Conversation

@cyrez
Copy link
Copy Markdown
Contributor

@cyrez cyrez commented Mar 12, 2026

Use %Y-%m-%d %H:%M:%S to return YYYY-MM-DD HH-MM-SS instead of %Y-%m-%d %H:%i:%s

%iwill not return anything and %sreturns a timestamp. So, not the expected result.

@qodo-code-review
Copy link
Copy Markdown
Contributor

Review Summary by Qodo

Fix PHP date format specifiers in calendar documentation

📝 Documentation

Grey Divider

Walkthroughs

Description
• Corrects PHP date format specifiers in calendar documentation
• Changes %H:%i:%s to %H:%M:%S for proper time formatting
• Fixes two occurrences in documentation and code example
Diagram
flowchart LR
  A["Incorrect format<br/>%H:%i:%s"] -- "Replace with<br/>correct PHP format" --> B["Correct format<br/>%H:%M:%S"]
Loading

Grey Divider

File Changes

1. docs/general-concepts/forms-fields/standard-fields/calendar.md 📝 Documentation +2/-2

Fix PHP date format specifiers in examples

• Corrects time format example from %Y-%m-%d %H:%i:%s to %Y-%m-%d %H:%M:%S in documentation text
• Fixes format attribute value in code example from %Y-%m-%d %H:%i:%s to %Y-%m-%d %H:%M:%S
• Uses proper PHP date format specifiers where %M represents minutes and %S represents seconds

docs/general-concepts/forms-fields/standard-fields/calendar.md


Grey Divider

Qodo Logo

@qodo-code-review
Copy link
Copy Markdown
Contributor

qodo-code-review bot commented Mar 12, 2026

Code Review by Qodo

🐞 Bugs (1) 📘 Rule violations (0) 📎 Requirement gaps (0)

Grey Divider


Remediation recommended

1. Versioned docs still wrong 🐞 Bug ✓ Correctness
Description
The PR fixes the time-format example in the unversioned Calendar field docs, but the same page in
versioned_docs/ still instructs users to use %H:%i:%s, leaving incorrect guidance published for
released versions. Users following those versioned docs will continue to configure calendar fields
with a non-working minutes/seconds format string.
Code

docs/general-concepts/forms-fields/standard-fields/calendar.md[22]

+  - If showtime is true then you will need to include some time fields, for example, '%Y-%m-%d %H:%M:%S'.
Evidence
The updated (unversioned) docs now show %H:%M:%S in both the descriptive bullet and the XML
example, but the versioned docs for multiple released versions still show the old %H:%i:%s text
and example, demonstrating an inconsistency that will keep misleading users who browse those
versions.

docs/general-concepts/forms-fields/standard-fields/calendar.md[18-23]
docs/general-concepts/forms-fields/standard-fields/calendar.md[62-72]
versioned_docs/version-6.0/general-concepts/forms-fields/standard-fields/calendar.md[20-23]
versioned_docs/version-6.0/general-concepts/forms-fields/standard-fields/calendar.md[64-70]
versioned_docs/version-4.4/general-concepts/forms-fields/standard-fields/calendar.md[22-25]

Agent prompt
The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

## Issue description
The Calendar field documentation was corrected in the unversioned docs, but the same guidance remains incorrect in multiple `versioned_docs/.../calendar.md` files. This leaves published released-version documentation still telling users to use `%H:%i:%s`.

## Issue Context
This repo contains multiple documentation versions under `versioned_docs/` that are served via the version switcher. Those pages currently include the outdated format example.

## Fix Focus Areas
- versioned_docs/version-4.4/general-concepts/forms-fields/standard-fields/calendar.md[22-25]
- versioned_docs/version-5.0/general-concepts/forms-fields/standard-fields/calendar.md[23-25]
- versioned_docs/version-5.1/general-concepts/forms-fields/standard-fields/calendar.md[23-25]
- versioned_docs/version-5.2/general-concepts/forms-fields/standard-fields/calendar.md[23-25]
- versioned_docs/version-5.3/general-concepts/forms-fields/standard-fields/calendar.md[20-23]
- versioned_docs/version-5.4/general-concepts/forms-fields/standard-fields/calendar.md[20-23]
- versioned_docs/version-6.0/general-concepts/forms-fields/standard-fields/calendar.md[20-23]

Also update the XML example blocks in those same files where `format=&quot;%Y-%m-%d %H:%i:%s&quot;` appears.

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools


Grey Divider

ⓘ The new review experience is currently in Beta. Learn more

Grey Divider

Qodo Logo

@robbiejackson
Copy link
Copy Markdown
Contributor

Thanks for fixing this.

Could you include these changes in the other versions as well, then we can merge this. That is, in the equivalent calendar.md file under versioned_docs/version-4.4, versioned_docs/version-5.4 and versioned_docs/version-6.0.

Those are the other versions we're also maintaining at the moment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants