[5.4][UX] hide container automated updates when install additional languages

[heelc29]

Summary of Changes

• hide container for opt-out of automated updates when install additional language (during installation process) 08a071f
• apply some codestyle for js files (mixed indentation) - these files are not under control of build tools 872e881

(If the code style adjustments are not desired, I can revert them)

Testing Instructions

• install joomla
• at the end select Install Additional Languages
• go back with Skip

2nd:

• disabled automated updates and check that the container will not displayed again if skipping language install

Actual result BEFORE applying this Pull Request

container for Automated Updates is displayed above Install Additional Languages

Expected result AFTER applying this Pull Request

container for Automated Updates is not displayed above Install Additional Languages

if skipping the installation of languages its will be displayed again (if not disabled before)

Link to documentations

Please select:

• No documentation changes for docs.joomla.org needed
• No documentation changes for manual.joomla.org needed

[ceford]

I have tested this item ✅ successfully on 22b3f24

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46275.}

[muhme]

I have tested this item 🔴 unsuccessfully on 22b3f24

Tested with JBT (simple removing joomla-5.4/configuration.php) checked before the PR with de-DE

• Installing additional languages shows Automated Updates first
• Disabled Automated Updates, Installed one language and Automated Updates container is shown again

Installed PR with graft from PR's full package and deleted joomla-5.4/configuration.php again:

• ✅ Installing additional languages shows only installing additional languages
  • Installed Japanese, Installing additional languages is again on the top and Spanish can be installed
• ✅ Disabling Automated Updates, Start to install additional languages and skip -> Automated Updates is not shown
• Deactivated Automated Updates
  • ❌ Installed Ukrainian as fourth language and Automated Updates is shown again, additonal default language selection is shown twice

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46275.}

[richard67]

additonal default language selection is shown twice

@muhme Are you sure? Your screenshots shows it one tome for the administrator and one time for the site. That's like it should be.

[muhme]

additonal default language selection is shown twice

@muhme Are you sure? Your screenshots shows it one tome for the administrator and one time for the site. That's like it should be.

You are right – default language selection is shown twice is not a problem. Thank you for clarification 👍

[richard67]

@muhme Could you correct your test result (and set RTC if 2nd test)?

[muhme]

@muhme Could you correct your test result (and set RTC if 2nd test)?

No, as the failed test was Automated Updates is shown again

Additionally @bembelimen states the fix is already done with #46403

[richard67]

@heelc29 Would you be ok with closing this PR in favour of PR #46403 ? I know, your PR is older, so it should come first, but it would cause us a few complications because the other one would have ugly merge conflicts.

[richard67]

Closing in favour of PR #46403 .

@heelc29 Thanks for this PR, which was the right fix. But we have decided to merge the other PR #46403 , which includes the same fix but also other fixes. Thanks also for your help with that PR. Merging both PRs would have caused us a bit more work due to the merge conflicts. I hope you are ok with that, and sorry for the inconvenience.