-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[6.0] Cassiopeia Extended - Use hover color for btn-primary #46279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
I have tested this item ✅ successfully on 8053f16 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46279. |
Contributor
Author
Contributor
|
yes, sorry my bad. |
|
I have tested this item ✅ successfully on fac0952 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46279. |
Contributor
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46279. |
Contributor
|
Thanks @drmenzelit nice catch, and thanks to @chmst and @dautrich for tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.


Pull Request for Issue # .
Summary of Changes
The CSS of the new child template is not using the hover color for the btn-primary as expected.
Testing Instructions
Check the selected colors in Colour Setting from Cassiopeia Extended
Create a link with the class "btn btn-primary"
Actual result BEFORE applying this Pull Request
The selected color for the button in hover status isn't in use, the hovered button as the same text color as the not hovered button
Set is
rgb(254, 254, 254)for the text color on hover. The button on hover has stillrgb(23, 23, 23)Expected result AFTER applying this Pull Request
The button use the selected color in hovered status
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed