[5.4] Update repeatable-table.php

[nordmograph]

Pull Request for Issue # .

Summary of Changes

The width was hardcoded to 45%, regardless of the number of columns. This change makes it dynamic, distributing the width according to the number of fields, while reserving 8% for the action column.

Testing Instructions

Create a subform 'test' field with a repeatable.table layout and at least 3 (text for eg.) fields in it.
(layout="joomla.form.field.subform.repeatable-table") + subform_test.xml

Actual result BEFORE applying this Pull Request

2 first fields have 45% as width and the 3rd and following ones are compressed

Expected result AFTER applying this Pull Request

the width of ech field is a divisiion of the total width per the amount of fields

Link to documentations

Please select:

• Documentation link for docs.joomla.org:

• No documentation changes for docs.joomla.org needed

• Pull Request link for manual.joomla.org:

• No documentation changes for manual.joomla.org needed

[chmst]

Tested and works perfectly.
I’d round it to two decimal places - this looks a bit weird:

[muhme]

@chmst Could you do an issue tracker test?

[chmst]

I have tested this item ✅ successfully on 3d4662a

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46287.}

[chmst]

Tested successfully: All columns have the same width.

[muhme]

@nordmograph I have tested this PR and see:

• before PR: <th scope="col" style="width:45%">
• with PR: <th scope="col" style="width:13.142857142857%">

However, there is no difference in the presentation for me on quick view in any of the three browsers (Firefox, Chrome, and Safari). All fields are present, and I can scroll horizontally before or after the PR. Could you please explain/show what bug this PR fixes?

[richard67]

@muhme Maybe you can see the effect only on small screens, e.g. mobile phone?

[chmst]

It is the calculation - before: every column has with: 45% which is not correct if there are more than 2 cloumns. Now, all columns have a correctly calculated width.
Users don't see a difference because the fields enforce the width they need and hoizontal scrolling is necessary.

[muhme]

@nordmograph and other testers: How to reproduce the problem? Which browser, under what circumstances, with a screenshot?

2 first fields have 45% as width and the 3rd and following ones are compressed

[Fedik]

@muhme try use different field types as @chmst did.

The fix mostly cosmetic, the width is ignored by Table (table use it as "relative width"), and example for all "text input" it will be equal for each cell.
With different content in the cell the result should be more visible.

[muhme]

Even with different content, all columns are equal in size:

Is there is not enough horicontal space, there is horicontel scrolling needed, but nothing is compressed:

After applying the PR with Patch Tester it looks identical as before. Sorry, I can't reproduce the problem.

[Fedik]

In some reason I expected it will be relive to content width, but as all columns have same width 45% the table make it equal also for any amount of columns.

But, as I said it just cosmetic changes, even if we set width:100% the table will "make it fit".

[muhme]

I have tested this item ✅ successfully on 21a6aed

Tested with JBT, the width is calculated dynamically for the number of fields.

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46287.}

[muhme]

RTC

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46287.}

[richard67]

Thanks @nordmograph for this fix, @chmst and @muhme for testing and @Fedik for support.