Skip to content

Conversation

@brianteeman
Copy link
Contributor

Pull Request for Issue #46618 .

Summary of Changes

Fix a missing scope for a menu item (MOD_MENU_HELP_PROGRAMMERS) in the alternate preset admin menu

Testing Instructions

Open Modules (Administrator) > Admin Menu
Choose Preset: Preset - Alternative Main Menu
Help Menu: set to HIDE
SAVE and Refresh

Actual result BEFORE applying this Pull Request

Using the alternate preset and With the help menu set to hide you see a partial help
menu

image

Expected result AFTER applying this Pull Request

Using the alternate preset and With the help menu set to hide then the help menu is removed

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

Signed-off-by: BrianTeeman <brian@teeman.net>
@samuelagus
Copy link

I have tested this item ✅ successfully on d196878


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46620.

1 similar comment
@tecpromotion
Copy link
Contributor

I have tested this item ✅ successfully on d196878


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46620.

@tecpromotion
Copy link
Contributor

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46620.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Dec 29, 2025
@richard67 richard67 added this to the Joomla! 5.4.3 milestone Jan 2, 2026
@muhme
Copy link
Contributor

muhme commented Jan 8, 2026

✅ Final test before merge with JBT

  • Seen the problem before PR, one help entry is shown even with hide Help Menu
  • Applied PR with gh pr checkout 46620
    • No Help menu entry if Help Menu is configured as Hide
    • If you select Show Help Menu, all the entries are shown

@muhme muhme merged commit a041c3c into joomla:5.4-dev Jan 8, 2026
69 checks passed
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Jan 8, 2026
@muhme
Copy link
Contributor

muhme commented Jan 8, 2026

Thank you @brianteeman for your contribution. Thank you @samuelagus and @tecpromotion for testing.

@brianteeman
Copy link
Contributor Author

Thanks

@brianteeman brianteeman deleted the help branch January 8, 2026 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants