Allow Icons component receive a className without type error#17
Open
taldr27 wants to merge 1 commit intojoschan21:masterfrom
Open
Allow Icons component receive a className without type error#17taldr27 wants to merge 1 commit intojoschan21:masterfrom
taldr27 wants to merge 1 commit intojoschan21:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is a type error when trying to add a className to the Icons component, we can add the className optional prop to the Icons component so we can receive the classname without any problems.
Note: The styles work fine until you try to build the project, then you'll get the error. My latest shadcn-ui version is 0.8.0
Error: