Fix test deployment workflow to run properly in PRs #207
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
All items in the checklist have been checked🎉 |
- Remove workflow_run trigger that caused workflow to run on main branch instead of PR branch - Add proper concurrency configuration to prevent conflicts with other workflows - Update paths-ignore to be more specific and allow workflow changes to trigger tests - Fixes #102
josh-wong
force-pushed
the
fix-test-deployment-workflow-102
branch
from
fedb4d2 to
adb4c2b
Compare
Contributor
|
All items in the checklist have been checked🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes issue #102 where the test deployment workflow was not running properly in pull requests.
Related issues and/or PRs
Changes made
Removed trigger: The trigger was causing the test deployment workflow to run on the main branch instead of the PR branch, and it wasn't showing up in the PR checks.
Added proper concurrency configuration: Added a concurrency group specific to this workflow to prevent conflicts while allowing it to run alongside the PR checklist checker.
Updated path exclusions: Changed from excluding all files to more specific exclusions, allowing workflow changes to trigger tests when appropriate.
Technical details
The root cause was the trigger which:
By removing this trigger and relying on the standard trigger with proper concurrency configuration, the workflow will now:
Checklist
The following is a best-effort checklist. If any items in this checklist aren't applicable to this PR, add
N/Aafter each item.Documentation
N/AN/ABuild, deploy, and test
N/AN/A