Update README.md #7
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is important to let people know that there is also Request argument passed. Also, in some cases, it is very important to have associative array and determining keys in callback. Please amend to address them. I have added also example. also, please make a small addition in readme, to describe what is "group" class in the repo, as i found no usage examples. Thanks for nice work.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is important to let people know that there is also Request argument passed.
Also, in some cases, it is very important to have associative array and determining keys in callback.
Please amend to address them. I have added also example.
also, please make a small addition in readme, to describe what is "group" class in the repo, as i found no usage examples.
Thanks for nice work.