Open
Conversation
-Added file size limit while uploading -Changed the label from image to attachment
Chetan-Satpute-Josh
suggested changes
Oct 11, 2024
|
|
||
| export const ImageS3Tag = ({ path }) => { | ||
| const [srcImg, setSrcImg] = useState<string | undefined>(); | ||
| export const MediaS3Tag = ({ path }: { path: string }) => { |
There was a problem hiding this comment.
I think the type definition affects readability in this case
- Define individual parameters with individual types
export const MediaS3Tag = (path: string) => {
- Define an interface for parameter object
interface MediaS3TagParams {
path: string;
}
export const MediaS3Tag = ({path}: MediaS3TagParams) => {
src/modules/shared/UploadBucket.tsx
Outdated
| const oversizedFile = selectedFiles.find((file) => file.size > MAX_FILE_SIZE); | ||
|
|
||
| if (oversizedFile) { | ||
| setErrorMessage(`File size exceeds limit: ${oversizedFile.name}`); |
There was a problem hiding this comment.
File exceeds size limit seems more clear?
| return <CircularProgress />; | ||
| } | ||
|
|
||
| if (fileType === 'pdf') { |
There was a problem hiding this comment.
We should'nt be dependent on file extension to determine file type.
-Added the view and Download button -Reframed the error message
Chetan-Satpute-Josh
suggested changes
Oct 24, 2024
Chetan-Satpute-Josh
left a comment
Chetan-Satpute-Josh
left a comment
There was a problem hiding this comment.
Please make changes discussed in the meeting.
-Used the usequery to fetch image
Chetan-Satpute-Josh
approved these changes
Nov 13, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
-Added feature can upload pdf ,vedio, excel
-Added file size limit while uploading
-Changed the label from image to attachment