Skip to content

Conversation

@kurtmckee
Copy link
Contributor

@kurtmckee kurtmckee commented Oct 23, 2025

This fixes two warnings that were causing Read the Docs builds to fail [recent example]:

WARNING: missing attribute mentioned in :members: option: module jwt.algorithms, attribute AllowedPrivateKeys [autodoc]
WARNING: missing attribute mentioned in :members: option: module jwt.algorithms, attribute AllowedPublicKeys [autodoc]

The warnings occurred because the crypto extra was not configured to be installed in the Read the Docs config file.

The problem was overlooked because the tox docs environment installed the crypto extra, so CI never failed.

This fixes two warnings that were causing Read the Docs builds to fail:

```
WARNING: missing attribute mentioned in :members: option: module jwt.algorithms, attribute AllowedPrivateKeys [autodoc]
WARNING: missing attribute mentioned in :members: option: module jwt.algorithms, attribute AllowedPublicKeys [autodoc]
```

The warnings occurred because the `crypto` extra
was not configured to be installed in the Read the Docs config file.

The problem was overlooked because the tox `docs` environment
installed the `crypto` extra.
@kurtmckee kurtmckee changed the title Add pyupgrade as a pre-commit hook Fix Read the Docs builds Oct 23, 2025
@kurtmckee
Copy link
Contributor Author

Hello @auvipy! Thank you for continuing to review and merge PRs!

When you have an opportunity, would you be willing to review this and other PRs that are open? Each PR targets specific issues in the project infrastructure and codebase. For example, Read the Docs builds have been failing for seven months, and this PR should resolve that infrastructure problem.

Thanks again for your work on pyjwt!

@auvipy auvipy merged commit f352404 into jpadilla:master Oct 29, 2025
29 checks passed
@kurtmckee kurtmckee deleted the fix-rtd-builds branch October 29, 2025 14:53
@kurtmckee
Copy link
Contributor Author

Thanks @auvipy! Read the Docs builds are now passing. 🥳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants