feat: make the paperweight check more flexible #146
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change is mainly targeted towards users which use custom paperweight forks needed to build some forks of paper etc, so they can also use the handy devbundle run task, as they cant just switch to paperweight in some cases
Author
|
Any chance this could be looked at sooner? It would be nice if so, as we’re getting closer to the official release of the project and we would greatly appreciate if this could be atleast given feedback before that happens. Thanks^ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is mainly targeted towards users which use custom paperweight forks needed to build some forks of paper etc, so they can also use the handy devbundle run task, as they cant just switch to paperweight.
The main motivation for this is a plugin project required for another project, that i’m working on which requires hooks in the userdev plugin forcing us to have a fork of it as it modifies the dev bundle’s jar artifact that’s going to be provided as the NMS dependency thus some code that compiles with those modifications can’t run on the
runServertask’s server instance and requires to be ran by the dev bundle server task, which is currently unavailable for us due to this strict check