-
Notifications
You must be signed in to change notification settings - Fork 20
Remove 3.6, 3.7, 3.8 from project's metadata and related dead code in the code base #214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove 3.6, 3.7, 3.8 from project's metadata and related dead code in the code base #214
Conversation
|
@rcaudy We want you to be aware of this change since it potentially impacts the scope of the maintenance of the product, and give you a chance to raise any objection to it. |
| #define JPY_COMPAT_33P 1 | ||
| #if PY_MINOR_VERSION >= 5 | ||
| #define JPY_COMPAT_35P 1 | ||
| #if PY_MAJOR_VERSION < 3 || PY_MINOR_VERSION < 9 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this precise enough? I'm assuming we should say we only support 3.x, and not a theoretical 4.x.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wouldn’t be concerned about Python 4. Not only is it unlikely to arrive anytime soon—if ever—but the Python core developers have made it clear they’ve learned from the painful transition between Python 2 and 3. If a Python 4 does eventually happen, preserving backward compatibility will be a top priority. The evolution from Python 3 onward is designed to be gradual, stable, and minimally disruptive.
This is to reflect that we no longer build distributions for these versions going forward, so no new bug fixes/features will be available for them. That said, if needed, users most likely should be able to port these changes themselves if the bug fixes or new features are not tied to newer versions of Python.
Fixes #213