Skip to content

Conversation

@ExE-Boss
Copy link
Contributor

@ExE-Boss ExE-Boss commented Feb 17, 2020

There are two top‑level tests named "utils.js", one is a describe in utils.test.js, the other is in test.js, this is generally un‑advised.

Blocks:


Best reviewed with whitespace‑only changes hidden: #170?w=1

@ExE-Boss ExE-Boss force-pushed the test/rename-generation-test branch from 5858a99 to 9f423d4 Compare March 6, 2020 02:57
@ExE-Boss ExE-Boss changed the title test: Rename generation test Rename wrapper generation test Apr 3, 2020
@ExE-Boss ExE-Boss force-pushed the test/rename-generation-test branch from 9f423d4 to fe4e3c4 Compare May 9, 2020 18:59
@ExE-Boss ExE-Boss changed the title Rename wrapper generation test Wrap generation test file in a describe May 9, 2020
@ExE-Boss ExE-Boss force-pushed the test/rename-generation-test branch from fe4e3c4 to 167aa52 Compare February 21, 2021 15:56
@TimothyGu TimothyGu merged commit 98d0aa4 into jsdom:master Feb 22, 2021
@TimothyGu TimothyGu deleted the test/rename-generation-test branch February 22, 2021 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants