Skip to content

Fix TypeError in pattern property validation with integer keys #880

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DannyvdSluijs merged 2 commits into from
Feb 13, 2026
+38 −1
Merged

Fix TypeError in pattern property validation with integer keys #880

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
530e229
Initial plan
Copilot Feb 13, 2026
4d9f918
Fix TypeError when using preg_match with integer keys in pattern prop…
Copilot Feb 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/JsonSchema/Constraints/ObjectConstraint.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ public function validatePatternProperties($element, ?JsonPointer $path, $pattern
continue;
}
foreach ($element as $i => $value) {
if (preg_match($fullRegex, $i)) {
if (preg_match($fullRegex, (string) $i)) {
$matches[] = $i;
$this->checkUndefined($value, $schema ?: new \stdClass(), $path, $i, in_array($i, $this->appliedDefaults));
}
Expand Down
37 changes: 37 additions & 0 deletions tests/Constraints/PatternPropertiesTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,4 +197,41 @@ public function getValidTests(): \Generator
])
];
}

public function getValidForAssocTests(): \Generator
{
// First yield all the regular valid tests
yield from $this->getValidTests();

// OpenAPI-like scenario with numeric keys (HTTP status codes)
// When JSON is decoded with associative=true, numeric keys become integers
yield 'validates OpenAPI responses with numeric status codes using assoc arrays' => [
json_encode([
'responses' => [
'200' => [
'description' => 'OK'
],
'404' => [
'description' => 'Not Found'
]
]
]),
json_encode([
'type' => 'object',
'properties' => [
'responses' => [
'type' => 'object',
'patternProperties' => [
'^[0-9]+$' => [
'type' => 'object',
'properties' => [
'description' => ['type' => 'string']
]
]
]
]
]
])
];
}
}
Loading