fix(transloco): 🐛 Avoid toObservable on signal API + string key #895
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simplifies the common use case of static keys / params for the signal APIs by avoiding the toObservable call, which uses the angular effect API to listen to changes from the signal and propogate those into the observable stream. Using the effect call causes the component to render twice, once with an empty string as the signal value and the second time asyncronously with the actual value. ✅ Closes: jsverse#894
@jsverse/transloco
@jsverse/transloco-locale
@jsverse/transloco-messageformat
@jsverse/transloco-optimize
@jsverse/transloco-persist-lang
@jsverse/transloco-persist-translations
@jsverse/transloco-preload-langs
@jsverse/transloco-schematics
@jsverse/transloco-scoped-libs
@jsverse/transloco-utils
@jsverse/transloco-validator
commit: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplifies the common use case of static keys / params for the signal APIs by avoiding the toObservable call, which uses the angular effect API to listen to changes from the signal and propogate those into the observable stream. Using the effect call causes the component to render twice, once with an empty string as the signal value and the second time asyncronously with the actual value.
✅ Closes: #894
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: #894
What is the new behavior?
This change simply removes the toObservable call for static use cases and replaces it with a basic
ofcall, thereby removing the async nature of toObservable.Does this PR introduce a breaking change?
Other information