fix: dm14 messages with data larger than 7 bytes #95
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix bugs in the handling of DM14 messages with data larger than 7 bytes. To handle DM14 messages with data larger than 255 bytes, add usage of the three most significant bits in the 11-bit length field for DM14 requests and DM15 responses. Add test cases for large DM14 messages. Also: - Fix wrong addresses in test data comments - Fix race conditions in Dm14Query and Dm14Server, when testing - Improve performance by replacing for-loop and .append() with .extend()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix bugs in the handling of DM14 messages with data larger than 7 bytes.
To handle DM14 messages with data larger than 255 bytes, add usage of the three most significant bits in the 11-bit length field for DM14 requests and DM15 responses.
Add test cases for large DM14 messages.
Also: