Remove the lock for IsConnectionAlive get method#6
Open
limaolm wants to merge 6 commits intojuhgiyo:masterfrom
Open
Remove the lock for IsConnectionAlive get method#6limaolm wants to merge 6 commits intojuhgiyo:masterfrom
limaolm wants to merge 6 commits intojuhgiyo:masterfrom
Conversation
change to use http for submodule
update to EpLibrary.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Woong,
Thanks for create and open source EpServerEngine.cs. It's a great project. However, I found the performance can be greatly improved in some case by a minor change. The get method of IsConnectionAlive property does not need to be guarded by m_generalLock lock. It's bool type. If a caller client need to query IsConnectionAlive in a loop, the unnecessary lock might introduce race condition/wait with other operations.
public bool IsConnectionAlive
{
get
{
lock (m_generalLock)
{
return m_isConnected;
}
}
private set
{
lock (m_generalLock)
{
m_isConnected = value;
}
}