Skip to content
This repository was archived by the owner on Mar 26, 2022. It is now read-only.

Fibonacci- The bot shows the next 5 numbers#10

Open
ragmha wants to merge 2 commits intojuhovan:fibonaccifrom
ragmha:fibonacci
Open

Fibonacci- The bot shows the next 5 numbers#10
ragmha wants to merge 2 commits intojuhovan:fibonaccifrom
ragmha:fibonacci

Conversation

@ragmha
Copy link
Copy Markdown

@ragmha ragmha commented Feb 23, 2016

No description provided.

@juhovan
Copy link
Copy Markdown
Owner

juhovan commented Feb 23, 2016

Feedback:

  • Separate branch and pull request for the changes, good
  • Works fine
  • .gitignore shouldn't be here as it's not part of changes stated in pull request
  • Try to avoid refactoring when making feature changes, do it in separate branch and pull request if required to ease reviewing (You removed some tabs from otherwise empty lines)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants