Skip to content
This repository was archived by the owner on Mar 26, 2022. It is now read-only.

Fix prime and fibonacci numbers#6

Open
ChanhLeNguyen wants to merge 22 commits intojuhovan:masterfrom
ChanhLeNguyen:master
Open

Fix prime and fibonacci numbers#6
ChanhLeNguyen wants to merge 22 commits intojuhovan:masterfrom
ChanhLeNguyen:master

Conversation

@ChanhLeNguyen
Copy link
Copy Markdown

Fix prime and fibonacci numbers

@juhovan
Copy link
Copy Markdown
Owner

juhovan commented Feb 23, 2016

Feedback:

  • It seems to work, good.
  • Next time please don't use master, otherwise everything you push to master will get included in pull request
  • Also please only do one feature change per branch and pull request to make it easier to review and make changes if there is something wrong
  • Also try not to commit changes like removing tab on otherwise empty line, it only makes it harder to review as github will highlight the change
    • If you need to refactor old code do it in separate branch & pull request

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants