This repository was archived by the owner on Mar 4, 2024. It is now read-only.
Open
Conversation
Allows a charm to lookup the ip address of a named network interface, or find a network interface that falls in a cidr range. Added tests, and fixed things so that tox will actually run test_utils.py.
| # address, even though interfaces on physical | ||
| # hardware will list this as their ipv6 ip. Just | ||
| # skip over this issue for now. | ||
| continue |
Contributor
There was a problem hiding this comment.
This should be something more like this:
for interface in interfaces:
for ip_version in (netifaces.AF_INET, netifaces.AF_INET6):
for address in netifaces.ifaddresses(interface)[ip_version]:
ip = address['addr']
ip = getattr(ip, 'decode', lambda e: ip)('utf8') # force unicode
ip = ipaddress.ip_address(ip)
if ip.is_link_local:
continue
if ip in ipaddress.ip_network(network_interface):
return ipSpecifically:
- Loop over all returned addresses, don't just try the first
- Use
is_link_local - I like
hasattr(..., 'decode')better thanencode/decode, but that's more personal preference
Squash this commit. Squash it into nothing!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows a charm to lookup the ip address of a named network interface, or
find a network interface that falls in a cidr range.
Added tests, and fixed things so that tox will actually run test_utils.py.
@juju-solutions/bigdata