Various fixes to KirlikSayin #108
Conversation
| yI, yN = zeros(n), zeros(n) | ||
| δ = sense == MOI.MIN_SENSE ? -1 : 1 | ||
| # This tolerance is really important! | ||
| δ = 1.0 |
There was a problem hiding this comment.
Is this tolerance arbitrary? Why 1.0?
There was a problem hiding this comment.
Since these algorithms target integer programs, the e-constraints enforces f_i(x) < u_i and the bound are integer as well.
| end | ||
| _, Y = _compute_point(model, variables, f_i) | ||
| yN[i] = Y | ||
| yN[i] = Y + δ |
There was a problem hiding this comment.
So the +1 (now + δ) was needed because we have a separate constraint that f_i <= u - δ. So the box bounds need to account for that?
There was a problem hiding this comment.
There was a +1 here because the \delta was for e-constraints. Having +1 makes it consistent with KS and DR. Original algorithm uses some big M.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #108 +/- ##
==========================================
- Coverage 98.78% 98.78% -0.01%
==========================================
Files 9 9
Lines 991 990 -1
==========================================
- Hits 979 978 -1
Misses 12 12 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Part of #105
Alternative to #107
I'll comment in-line.