-
Notifications
You must be signed in to change notification settings - Fork 11
Support many more MPFR functions #342
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
projekter
wants to merge
12
commits into
jump-dev:master
Choose a base branch
from
projekter:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #342 +/- ##
==========================================
- Coverage 89.86% 86.86% -3.00%
==========================================
Files 22 22
Lines 2141 2208 +67
==========================================
- Hits 1924 1918 -6
- Misses 217 290 +73 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
Yes, I would welcome the addition, the macro makes implementing them quite compact! I would deal with |
- Therefore, remove special handling - the types already include Int and UInt - Add floating point type - Enhance macro: allow for pre- and postprocessing as well as custom parameter names
…versions, consistent with Base in newer ones)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I recently saw that MutableArithmetics does not support most of the functions that MPFR offers, only the basic arithmetic and assignment stuff. Actually, I needed it for assignment of (bit) integer values, but when I looked at it, I thought that just implementing the whole bunch of functions is not much more effort once you have a nice macro to automate it.
So in this PR:
However:
SpecialFunctions.jland implement the functions from there that are part of MPFR.If you want this to proceed, I think tests should be part of this PR, but the other two points could also be separate...