Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #380 +/- ##
==========================================
- Coverage 84.46% 82.32% -2.15%
==========================================
Files 41 42 +1
Lines 2511 2585 +74
==========================================
+ Hits 2121 2128 +7
- Misses 390 457 +67 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
blegat
commented
Apr 21, 2026
| @@ -0,0 +1,116 @@ | |||
| import QuantumStuff: trace_monoid, Monoids | |||
Member
Author
There was a problem hiding this comment.
@kalmarek Any suggestion to get these with one of your released packages ?
blegat
commented
Apr 21, 2026
| ) | ||
| end | ||
| else | ||
| @warn("$mono not in basis") |
Member
Author
There was a problem hiding this comment.
We should error, weird that it was ignored before
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@kalmarek I'll wait for KnuthBendix to integrate
Monoidsbefore merging this, I'll leave it as a WIP for now.I needed a workaround with
Fullfor it to work with theKernelBridge, it's not ideal as it is ignoring theMTable. Maybe it would be resolved by something similar to:JuliaAlgebra/StarAlgebras.jl#55
Needs
Closes #364