Skip to content

Mark jumpstarter-client-secret as optional #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
NickCao wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Mark jumpstarter-client-secret as optional #16

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3a8f996
Mark jumpstarter-client-secret as optional
NickCao Aug 5, 2025
167fd4f
[HACK] do not echo the script
NickCao Aug 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tasks/get-lease/get-lease.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,4 +77,4 @@ spec:
- description: Workspace for mounting Jumpstarter client files.
mountPath: /root/.config/jumpstarter/clients
name: jumpstarter-client-secret

optional: true
2 changes: 1 addition & 1 deletion tasks/release-lease/release-lease.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,4 +60,4 @@ spec:
workspaces:
- mountPath: /root/.config/jumpstarter/clients
name: jumpstarter-client-secret

optional: true
Copy link

@coderabbitai coderabbitai bot Aug 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion

Same caveat as in get-lease: releasing without a mounted client may fail
With optional: true, the task now starts even when the jumpstarter-client-secret workspace is missing. If the client-config param is also empty, the later jmp config client use … will not find a config and the lease-release will error. Add a safety check or document the expectation in the Task description.

🤖 Prompt for AI Agents 
In tasks/release-lease/release-lease.yaml at line 63, the use of 'optional:
true' allows the task to start without the 'jumpstarter-client-secret'
workspace, which can cause errors later if 'client-config' is also empty. To fix
this, add a conditional check before running 'jmp config client use' to ensure
the client config is present, or update the Task description to clearly document
that the workspace or client-config must be provided to avoid lease-release
failures.

9 changes: 5 additions & 4 deletions tasks/run-cmd/run-cmd.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,10 +62,9 @@ spec:
# Set the Jumpstarter lease environment variable
export JMP_LEASE="$(params.jmp-lease-id)"

# Show the command that will be executed
echo "Running: $(params.jmp-jScript)"

cd /workspace/source
if [ "$(workspaces.source.bound)" == "true" ] ; then
cd "$(workspaces.source.path)"
fi

# Execute the script commands within the Jumpstarter shell
jmp shell --lease "${JMP_LEASE}" <<-EOF
Expand All @@ -77,5 +76,7 @@ spec:
- description: Workspace for mounting Jumpstarter client files.
mountPath: "$(params.home)/.config/jumpstarter/clients"
name: jumpstarter-client-secret
optional: true
- description: Workspace containing the source code / build images
name: source
optional: true
2 changes: 1 addition & 1 deletion tasks/setup-sa-client/setup-sa-client.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,4 +58,4 @@ spec:
cp ${CONFIG_DIR}/default.yaml $(results.config.path)
workspaces:
- name: config-dir
description: The workspace which contains Jumpstarter client config file
description: The workspace which contains Jumpstarter client config file