fix: Problem using 'execute' action invoked via HTTP POST-request #4648
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When an execute action is triggered via HTTP POST (external source), fzf's GetChar() goroutine was already blocking on tty read. Any keystroke intended for the executed command might have been captured by the blocking GetChar call instead of going to the subprocess. This fix: 1. Tracks when actions come from external sources (HTTP POST via serverInputChan) 2. After execute completes for external actions, drains any captured keystroke from keyChan with a short timeout 3. Resets the flag at the end of each loop iteration Fixes junegunn#4524 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> Signed-off-by: majiayu000 <1835304752@qq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4524
Summary
When execute is triggered via HTTP POST, fzf's GetChar() goroutine was already blocking on tty read. Any keystroke intended for the executed command (e.g., 'q' to quit less) was captured by the blocking GetChar call instead of going to the subprocess.
Changes
🤖 Generated with Claude Code