fix(reports): allow local report commands to run without live pricing#375
Merged
junhoyeo merged 2 commits intojunhoyeo:mainfrom Apr 6, 2026
Merged
Conversation
Contributor
|
@IvGolovach is attempting to deploy a commit to the Inevitable Team on Vercel. A member of the Team first needs to authorize it. |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
…icing # Conflicts: # crates/tokscale-cli/src/main.rs # crates/tokscale-cli/tests/cli_tests.rs # crates/tokscale-core/src/lib.rs
junhoyeo
added a commit
that referenced
this pull request
Apr 7, 2026
Add totalCost assertions to existing offline-no-cache tests, stale-cache tests for monthly and graph commands, and a test proving submit still fails offline with strict pricing guard. Constraint: embedded costs from OpenCode fixtures (0.05+0.03+0.02=0.10) are preserved when pricing is None Constraint: stale-cache pricing overrides embedded costs (totalCost=0.0209) Confidence: high Scope-risk: narrow
7 tasks
junhoyeo
added a commit
that referenced
this pull request
Apr 7, 2026
* test(cli): add missing offline report coverage from PR #375 review Add totalCost assertions to existing offline-no-cache tests, stale-cache tests for monthly and graph commands, and a test proving submit still fails offline with strict pricing guard. Constraint: embedded costs from OpenCode fixtures (0.05+0.03+0.02=0.10) are preserved when pricing is None Constraint: stale-cache pricing overrides embedded costs (totalCost=0.0209) Confidence: high Scope-risk: narrow * fix(test): assert submit offline test fails due to pricing, not bad args The test was passing because --no-spinner is not a valid submit flag, causing an argument parse error instead of a pricing failure. Removed --no-spinner (submit doesn't have it), added stderr assertions to verify failure is from pricing/network error path, not auth or args. Confidence: high Scope-risk: narrow
Owner
|
@IvGolovach deployed in https://github.com/junhoyeo/tokscale/releases/tag/v2.0.20! thanks a lot 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
Local report commands currently abort when LiteLLM or OpenRouter pricing cannot be fetched, even though the underlying token and message data comes from local session files. That makes Tokscale unnecessarily fragile offline, behind strict firewalls, or during temporary network outages. This change keeps local reporting available without requiring live pricing.
Diff scope
graphso it can degrade gracefully without live pricingsubmitandwrappedTest proof
cargo test -p tokscale-core442 passed, 0 failed, 1 ignoredcargo test -p tokscale-cli294 passed, 0 failed, 1 ignored70 passed, 0 failedcargo clippy -p tokscale-core --all-features -- -D warningscargo clippy -p tokscale-cli --all-features -- -D warningscargo fmt --all --checkgit diff --checkVerification-pack proof
Not applicable - CLI/core local reporting change only.
Migration notes
Not applicable - no schema or data migration.
CI context confirmation
CI context names unchanged.
Rollback plan
git revert <merge_commit_sha>git revert <squash_commit_sha>Known residual risks
--offlineor--no-pricingflag; it makes local report commands degrade gracefully when live pricing is unavailablesubmitandwrappedintentionally keep their existing behavior in this PR scopeRelated