chore(ci): add frontend API validation workflow#381
Open
IvGolovach wants to merge 2 commits intojunhoyeo:mainfrom
Open
chore(ci): add frontend API validation workflow#381IvGolovach wants to merge 2 commits intojunhoyeo:mainfrom
IvGolovach wants to merge 2 commits intojunhoyeo:mainfrom
Conversation
Contributor
|
@IvGolovach is attempting to deploy a commit to the Inevitable Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
There was a problem hiding this comment.
2 issues found across 1 file
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name=".github/workflows/frontend_api_validation.yml">
<violation number="1" location=".github/workflows/frontend_api_validation.yml:3">
P2: Workflow lacks explicit `permissions`, leaving GITHUB_TOKEN scope to defaults; restrict to least-privilege (e.g., `contents: read`) since this job only runs tests.</violation>
<violation number="2" location=".github/workflows/frontend_api_validation.yml:26">
P2: Third-party GitHub Action is referenced by a mutable tag instead of a pinned commit SHA, which increases supply-chain risk.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
Right now, the repository's built-in GitHub Actions checks mainly cover Rust paths. That leaves
packages/frontend/**without a repo-owned validation gate, even though the project already has meaningful frontend API and library test coverage. This change closes that gap with the smallest reliable workflow that fits the current state ofmain.Diff scope
.github/workflows/frontend_api_validation.ymlpushandpull_requestevents whenpackages/frontend/**,package.json, orbun.lockchangebun install --frozen-lockfile, and run the existing frontend API and lib Vitest suitesmainstill has an unrelated typecheck blocker outside this diffTest proof
bun install --frozen-lockfilebun x vitest run packages/frontend/__tests__/api/*.test.ts packages/frontend/__tests__/lib/*.test.ts15 files, 113 tests passedgit diff --checkVerification-pack proof
Not applicable - this PR adds a small repo-owned workflow but does not change runtime logic, infrastructure, or migration behavior.
Migration notes
Not applicable - no schema or data migration.
CI context confirmation
CI context names unchanged.
Rollback plan
git revert <merge_commit_sha>git revert <squash_commit_sha>Known residual risks
mainstill has an unrelated missing-asset error inBlackholeHero.tsxthat this PR does not introduce or change