This repository was archived by the owner on Feb 2, 2018. It is now read-only.
Fix so CSS gets included in header for Redmine 1.2.0#13
Open
jamesvl wants to merge 1 commit intojuno:masterfrom
jamesvl:master
Open
Fix so CSS gets included in header for Redmine 1.2.0#13jamesvl wants to merge 1 commit intojuno:masterfrom jamesvl:master
jamesvl wants to merge 1 commit intojuno:masterfrom
jamesvl:master
Conversation
Changes in 1.2.0 now permit CSS to be included only on pages that have wiki editing boxes on them. See http://www.redmine.org/projects/redmine/repository/revisions/5239/entry/trunk/lib/redmine/wiki_formatting/textile/helper.rb Also changed back how we generate the URL to the syntax helper - it seems Rails 2.3.11 changes the previous behavior, and non-standard install locations get properly referenced.
|
+1 to apply this PR. The plugin does not render toolbar icons without this fix. |
|
Yes, please apply this pull request to fix the exploded toolbar! |
Owner
|
sorry for late response. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous
heads_for_wiki_formatterfunction is not getting called by Redmine'slayouts/base.rhtml. (see Redmine r5239)Patch also takes advantage of changes that permit this plugin's CSS to be included only on pages that have wiki editing boxes on them. (See the textile helper.rb file.)
Also reverted how we generate the URL to the syntax help page - it seems Rails 2.3.11 fixes the previous behavior, and non-standard install locations get properly referenced.