-
Notifications
You must be signed in to change notification settings - Fork 41
Update to JupyterLite 0.7.0rc0 #240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
pyproject.toml
Outdated
| dev = [ | ||
| "build", | ||
| "hatch", | ||
| "jupyterlab >=4.5.0rc0,<4.6.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
>=4.5.0,<4.6.0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yep, coming
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's kind of a bummer there's no way to reference build-system from optional-dependencies (or the new shiny dependency-groups)
| import { KernelMessage } from '@jupyterlab/services'; | ||
|
|
||
| import { DriveFS } from '@jupyterlite/contents'; | ||
| import { DriveFS } from '@jupyterlite/services'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oof, this increases the worker bundle size by 50%. Perhaps a deeper lib/ path would shake better?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What numbers are you seeing?
| [tool.jupyter-releaser.hooks] | ||
| before-bump-version = [ | ||
| "python -m pip install 'jupyterlab~=4.5.0rc0'", | ||
| "python -m pip install 'jupyterlab~=4.5.0'", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we actually could start using dependency-groups for this... or at least, that's my understanding (we don't want to install the package-under-dev).
|
@bollwyvl do you think these should be addressed in this PR? Or can we look into them separately, maybe before the |
|
|
... and again, have tried a whole mess of things to get the workers to play nice-nice with module federation so this wasn't even an issue. i had something that kinda worked with a nasty mess:
... but i hated it 👿 |
|
From https://github.com/jupyterlite/pyodide-kernel/actions/runs/19512304322/job/55854919639?pr=240 It seems it was mostly related to the dynamic import. |
bollwyvl
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shook down all the reasonable notebooks from upstream on RTD, a couple at a time, and didn't see any flake (though it didn't somehow fix sqlite 😿 )... LGTM!
https://github.com/jupyterlite/jupyterlite/releases/tag/v0.7.0rc0
@jupyterlaband@jupyterlitepackages@jupyterlite/services