Skip to content

Add cast container routes to resolve issue #1553 #78

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
heros-os wants to merge 3 commits into
base: nexus
Choose a base branch
from
Open

Add cast container routes to resolve issue #1553 #78

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6285583
Add cast container routes to resolve issue #1553
heros-os Jan 3, 2026
c599692
Merge pull request #1 from heros-os/feature/cast-container-routes
heros-os Jan 3, 2026
44e7286
Update CAST_ROUTES.md
heros-os Jan 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
241 changes: 241 additions & 0 deletions CAST_ROUTES.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,241 @@
# Cast Container Routes

## Overview

Script.skinvariables now provides routes to populate containers with cast information from Kodi's local database. This addresses issue #1553 by enabling cast display when using `call_auto` with `add_dbid`.

## Available Routes

### Movie Cast
Retrieves cast information for a movie by its database ID.

**Route:** `get_dbitem_movie_cast`

**URL Format:**
```
plugin://script.skinvariables/?info=get_dbitem_movie_cast&dbid=<movieid>
```

**Example:**
```xml
<onclick>Container(50).Update(plugin://script.skinvariables/?info=get_dbitem_movie_cast&dbid=$INFO[ListItem.DBID])</onclick>
```

### TV Show Cast
Retrieves cast information for a TV show by its database ID.

**Route:** `get_dbitem_tvshow_cast`

**URL Format:**
```
plugin://script.skinvariables/?info=get_dbitem_tvshow_cast&dbid=<tvshowid>
```

**Example:**
```xml
<onclick>Container(50).Update(plugin://script.skinvariables/?info=get_dbitem_tvshow_cast&dbid=$INFO[ListItem.DBID])</onclick>
```

### Episode Cast
Retrieves cast information for an episode by its database ID.

**Route:** `get_dbitem_episode_cast`

**URL Format:**
```
plugin://script.skinvariables/?info=get_dbitem_episode_cast&dbid=<episodeid>
```

**Example:**
```xml
<onclick>Container(50).Update(plugin://script.skinvariables/?info=get_dbitem_episode_cast&dbid=$INFO[ListItem.DBID])</onclick>
```

## Cast ListItem Properties

Each cast member in the container has the following properties:

| Property | Description | Example |
|----------|-------------|---------|
| `Label` | Actor name | "Robert Downey Jr." |
| `Label2` | Character/Role name | "Tony Stark" |
| `Art(thumb)` | Actor thumbnail image | "image://http%3a%2f%2f..." |
| `Property(name)` | Actor name (property) | "Robert Downey Jr." |
| `Property(role)` | Character name (property) | "Tony Stark" |
| `Property(order)` | Cast order | "0" |
| `Property(index)` | Zero-based index | "0" |
| `Property(thumbnail)` | Actor thumbnail URL | "image://http%3a%2f%2f..." |

## Skin XML Examples

### Basic Cast List

```xml
<control type="list" id="50">
<left>100</left>
<top>200</top>
<width>1720</width>
<height>600</height>
<onleft>9000</onleft>
<onright>9000</onright>
<onup>50</onup>
<ondown>50</ondown>
<orientation>horizontal</orientation>
<itemlayout width="200" height="300">
<control type="image">
<left>10</left>
<top>10</top>
<width>180</width>
<height>270</height>
<texture>$INFO[ListItem.Art(thumb)]</texture>
<aspectratio>scale</aspectratio>
</control>
<control type="label">
<left>10</left>
<top>285</top>
<width>180</width>
<height>30</height>
<label>$INFO[ListItem.Label]</label>
<font>font12</font>
<textcolor>white</textcolor>
<align>center</align>
</control>
<control type="label">
<left>10</left>
<top>315</top>
<width>180</width>
<height>25</height>
<label>$INFO[ListItem.Label2]</label>
<font>font10</font>
<textcolor>grey</textcolor>
<align>center</align>
</control>
</itemlayout>
<focusedlayout width="200" height="300">
<control type="image">
<left>10</left>
<top>10</top>
<width>180</width>
<height>270</height>
<texture>$INFO[ListItem.Art(thumb)]</texture>
<aspectratio>scale</aspectratio>
<bordertexture border="5">colors/white.png</bordertexture>
<bordersize>5</bordersize>
</control>
<control type="label">
<left>10</left>
<top>285</top>
<width>180</width>
<height>30</height>
<label>$INFO[ListItem.Label]</label>
<font>font12_title</font>
<textcolor>white</textcolor>
<align>center</align>
</control>
<control type="label">
<left>10</left>
<top>315</top>
<width>180</width>
<height>25</height>
<label>$INFO[ListItem.Label2]</label>
<font>font10</font>
<textcolor>grey</textcolor>
<align>center</align>
</control>
</focusedlayout>
</control>
```

### Updating Cast Container on Info Dialog Open

```xml
<!-- In DialogVideoInfo.xml -->
<onload>Container(50).Update(plugin://script.skinvariables/?info=get_dbitem_$INFO[ListItem.DBType]_cast&dbid=$INFO[ListItem.DBID])</onload>
```

### Conditional Cast Display

```xml
<!-- Show cast list only when container has items -->
<control type="group">
<visible>Integer.IsGreater(Container(50).NumItems,0)</visible>
<control type="label">
<label>Cast</label>
</control>
<control type="list" id="50">
<!-- cast list control -->
</control>
</control>
```

### Accessing Specific Cast Members

```xml
<!-- First cast member -->
<control type="label>
Copy link

Copilot AI Jan 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing closing double quote in the XML opening tag. The attribute 'type' should be properly quoted as 'type="label"' instead of 'type="label>'.

Copilot uses AI. Check for mistakes.
Copy link
Author

@heros-os heros-os Jan 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot open a new pull request to apply changes based on this feedback

Copy link
Owner

@jurialmunkey jurialmunkey Jan 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove this file. Documentation should be done in the Wiki not as files.

<label>$INFO[Container(50).ListItem(0).Label]</label>
</control>

<!-- Second cast member -->
<control type="label>
Copy link

Copilot AI Jan 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing closing double quote in the XML opening tag. The attribute 'type' should be properly quoted as 'type="label"' instead of 'type="label>'.

Copilot uses AI. Check for mistakes.
Copy link
Author

@heros-os heros-os Jan 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot open a new pull request to apply changes based on this feedback

<label>$INFO[Container(50).ListItem(1).Label]</label>
</control>

<!-- Number of cast members -->
<control type="label>
Copy link

Copilot AI Jan 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing closing double quote in the XML opening tag. The attribute 'type' should be properly quoted as 'type="label"' instead of 'type="label>'.

Copilot uses AI. Check for mistakes.
Copy link
Author

@heros-os heros-os Jan 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot open a new pull request to apply changes based on this feedback

<label>Cast: $INFO[Container(50).NumItems]</label>
</control>
```

## Integration with TMDb Helper

When using with plugin.video.themoviedb.helper's `call_auto` feature:

```xml
<onclick>RunScript(plugin.video.themoviedb.helper,add_dbid=$INFO[ListItem.DBID],tmdb_type=movie,call_auto=1190)</onclick>
```

The cast container will now be properly populated when the info dialog opens, thanks to the new cast routes.

## Requirements

- **script.skinvariables:** v2.1.35+
- **script.module.jurialmunkey:** v0.2.30+
- **Kodi Version:** 19+ (Nexus)

## Notes

- Cast data is retrieved from Kodi's local database
- No external API calls are made
- Cast members are ordered by their billing order (as scraped)
- If a movie/show has no cast data, the container will be empty
- Thumbnails are automatically loaded from Kodi's artwork cache

## Troubleshooting

**Container not populating:**
- Verify the container ID (50 in examples) exists in your skin XML
- Check that the media item has cast data in the Kodi library
- Ensure script.module.jurialmunkey is updated to v0.2.30 or higher

**Thumbnails not showing:**
- Verify artwork scrapers are enabled in Kodi settings
- Check that Kodi's artwork downloader has run
- Ensure sufficient cache space for artwork

**Wrong cast information:**
- Verify the correct `info` parameter is used (movie_cast vs tvshow_cast vs episode_cast)
- Check that the correct DBID is being passed
- Rescrape the media item if data appears incorrect

## Related Issues

- [Issue #1553](https://github.com/jurialmunkey/plugin.video.themoviedb.helper/issues/1553) - Empty Cast Container with call_auto and add_dbid

## Changelog

### v2.1.35
- Added `get_dbitem_movie_cast` route
- Added `get_dbitem_tvshow_cast` route
- Added `get_dbitem_episode_cast` route
- Updated dependency on script.module.jurialmunkey to v0.2.30
4 changes: 2 additions & 2 deletions addon.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
<?xml version="1.0" encoding="UTF-8"?>
<addon id="script.skinvariables"
version="2.1.34"
version="2.1.35"
Copy link
Owner

@jurialmunkey jurialmunkey Jan 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert this version bump. Version bumps should be done as a separate commit when a release is made not when the code base changes.

name="Skin Variables"
provider-name="jurialmunkey">
<requires>
<import addon="xbmc.python" version="3.0.0" />
<import addon="script.module.jurialmunkey" version="0.2.28" />
<import addon="script.module.jurialmunkey" version="0.2.30" />
<import addon="script.module.infotagger" version="0.0.5" />
</requires>
<extension point="xbmc.python.script" library="script.py" />
Expand Down
9 changes: 9 additions & 0 deletions resources/lib/plugin.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,15 @@ class Plugin():
'get_dbitem_addon_details': {
'module_name': 'jurialmunkey.jrpcid',
'import_attr': 'ListGetAddonDetails'},
'get_dbitem_movie_cast': {
'module_name': 'jurialmunkey.jrpcid',
'import_attr': 'ListGetMovieCast'},
'get_dbitem_tvshow_cast': {
'module_name': 'jurialmunkey.jrpcid',
'import_attr': 'ListGetTVShowCast'},
'get_dbitem_episode_cast': {
'module_name': 'jurialmunkey.jrpcid',
'import_attr': 'ListGetEpisodeCast'},
'get_number_sum': {
'module_name': 'resources.lib.lists.koditools',
'import_attr': 'ListGetNumberSum'},
Expand Down